RFR: 8308984: Relativize last_sp (and top_frame_sp) in interpreter frames

Fredrik Bredberg fbredberg at openjdk.org
Thu Aug 17 08:49:34 UTC 2023


On Wed, 16 Aug 2023 09:20:07 GMT, Andrew Haley <aph at openjdk.org> wrote:

> Sure, but we need to see what they point to. In other words, every relativized point should be _decoded_ into its pointer form. Otherwise relativization, a good thing, becomes obfuscation, a bad thing.

I see what you mean, but It can also be very confusing if you use a debugger to hex dump the memory were the fixed frame is located, and you see something else than is shown by frame::describe.

My opinion is that it's important to show the relativzed pointers the same way, regardless if they are on the stack or on the heap. And also somehow show that they are relativized.

Also since this PR is really just about relativizing last_sp, I think it would be nice if it could be integrated with the small change I did to frame::describe. After that I can create a new issue to handle the broader picture of how to show relativized pointers in frame::describe.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14545#issuecomment-1681883545


More information about the hotspot-dev mailing list