RFR: 8303852: current_stack_region() gets called twice unnecessarily [v2]

[David Holmes]

On Fri, 18 Aug 2023 06:12:44 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Excess newlines
>>  - Add spaces around operator
>
> src/hotspot/os/linux/os_linux.cpp line 5412:
> 
>> 5410:         fatal("pthread_attr_getguardsize failed with error = %d", rslt);
>> 5411:       }
>> 5412:       bottom += guard_size;
> 
> Why do we keep correcting bottom?

So we can check it in the assert at the end.

> src/hotspot/os/linux/os_linux.cpp line 5428:
> 
>> 5426: }
>> 5427: 
>> 5428: 
> 
> nit: lose some newlines?

Done

> src/hotspot/os/windows/os_windows.cpp line 444:
> 
>> 442:   // AllocationBase.
>> 443:   while (1) {
>> 444:     VirtualQuery(stack_bottom+size, &minfo, sizeof(minfo));
> 
> nit: spaces around +, since you are here?

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15321#discussion_r1299444812
PR Review Comment: https://git.openjdk.org/jdk/pull/15321#discussion_r1299445095
PR Review Comment: https://git.openjdk.org/jdk/pull/15321#discussion_r1299444992