RFR: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()

David Holmes dholmes at openjdk.org
Thu Aug 24 06:02:26 UTC 2023


On Mon, 17 Jul 2023 11:21:47 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> [small cleanup/enhancement] Adds & updates some code to use `interpreter_frame_monitor_size_in_bytes()` method. I wasn't sure whether we should remove it from PPC & S390 implementation or add it to other archs. For now I have added it but will be happy to revert as PR reviews. 
> 
> For s390 `interpreter_frame_interpreterstate_size_in_bytes()` was also cleaned up as it is not being used.
> 
> fastdebug build tested on **s390** & **apple m1-pro**.

This seems reasonable in principle, but given that this definition

inline int frame::interpreter_frame_monitor_size_in_bytes() {
  return frame::interpreter_frame_monitor_size() * wordSize;
}

is the same on all platforms then we should define it in  ./share/runtime/frame.inline.hpp

Thanks.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14902#pullrequestreview-1592831988


More information about the hotspot-dev mailing list