RFR: 8314502: GrowableArray: Make find with comparator take template

[Johan Sjölen]

On Thu, 24 Aug 2023 14:09:46 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

> The `find` method now is 
> ```C++
> template<typename T>
> int find(T* token, bool f(T*, E)) const {
> ...
> 
> Any other functions which use this are also changed.
> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and Windows passed.

Looks good to me, thank you. A couple of style issues that needs to be fixed, some pre-existing.

src/hotspot/share/prims/jvmtiImpl.cpp line 126:

> 124:   assert(e2 != nullptr, "e2 != nullptr");
> 125: 
> 126:   return v->equals(e2);

Please rename the `v` parameter to `e1`

src/hotspot/share/prims/jvmtiImpl.hpp line 91:

> 89:   void (*_listener_fun)(void *, address*);
> 90: 
> 91:   static bool equals(GrowableElement *, GrowableElement *);

Remove spacing between `GrowableElement` and `*`

-------------

Marked as reviewed by jsjolen (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15418#pullrequestreview-1594030652
PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1304600705
PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1304602700