Older unused Intel platform check functions

[David Holmes]

Hi Bernd,

On 25/08/2023 9:23 am, Bernd Eckenfels wrote:
> Hello,
> 
> I was checking out to see a hint of what’s the minimum microarchitecture 
> is, which makes sense to require for OpenJDK. I was not very successful 
> and it probably depends on compiler toolchain and distribution. Does 
> somebody have some insights?
> 
> Having said that I noticed the following:
> 
> The 20 years old netburst architecture has a test function but it’s not 
> used to make feature decisions in the JDK, it is just used to construct 
> a SSE feature string, where it can be safely removed (the feature flags 
> are reported anyway, worst case use cpu_family_description instead?)
> 
> VM_Version::is_netburst
> 
> If you want to keep it, it’s probably more consistent to rename it to 
> is_intel_netburst

Yes netburst seem unused now.

> 
> VM_Version::is_default_intel_cascadelake
> VM_Version::is_intel_cascadelake
> 
> Those two seem not to be used anywhere, can probably be removed as well.

Yes they are used: ./cpu/x86/x86.ad ./cpu/x86/x86_64.ad

Cheers,
David
----

> https://github.com/openjdk/jdk/blob/2624324ac216aadc938a870075f6fad287fedf05/src/hotspot/cpu/x86/vm_version_x86.hpp#L716 <https://github.com/openjdk/jdk/blob/2624324ac216aadc938a870075f6fad287fedf05/src/hotspot/cpu/x86/vm_version_x86.hpp#L716>
> 
> Greetings
> Bernd
> 
> 
> -- 
> http://bernd.eckenfels.net