RFR: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes() [v4]

David Holmes dholmes at openjdk.org
Fri Aug 25 06:32:11 UTC 2023


On Fri, 25 Aug 2023 06:27:24 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> [small cleanup/enhancement] Adds & updates some code to use `interpreter_frame_monitor_size_in_bytes()` method. I wasn't sure whether we should remove it from PPC & S390 implementation or add it to other archs. For now I have added it but will be happy to revert as PR reviews. 
>> 
>> For s390 `interpreter_frame_interpreterstate_size_in_bytes()` was also cleaned up as it is not being used.
>> 
>> fastdebug build tested on **s390** & **apple m1-pro**.
>
> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits:
> 
>  - remove extra line
>  - addition nits
>  - address @dholmes-ora suggestions
>  - updates header year
>  - risc-v
>  - arm
>  - x86
>  - aarch
>  - ppc
>  - s390

Ah not a rebase and force push! Just update your master branch, do `git merge master` then `git push` to update the PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14902#issuecomment-1692836193


More information about the hotspot-dev mailing list