RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method

Afshin Zafari azafari at openjdk.org
Fri Aug 25 08:07:11 UTC 2023


On Thu, 24 Aug 2023 16:38:55 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> The `find` method now is 
>> ```C++
>> template<typename T>
>> int find(T* token, bool f(T*, E)) const {
>> ...
>> 
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and Windows passed.
>
> src/hotspot/share/prims/jvmtiImpl.hpp line 91:
> 
>> 89:   void (*_listener_fun)(void *, address*);
>> 90: 
>> 91:   static bool equals(GrowableElement *, GrowableElement *);
> 
> Remove spacing between `GrowableElement` and `*`

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1305332211


More information about the hotspot-dev mailing list