Older unused Intel platform check functions

[David Holmes]

On 26/08/2023 3:13 am, Bernd wrote:
> Hello David.
> 
> Thanks for the hint (GitHub search seems to swallow that)
> 
> (Is x86_32.ab used in 64Bit builds?)

I don't think so, but compiler folk would need to confirm that.

> Btw regarding my initial question, the only requirement I have seen so 
> far are asserts asking for SSE2 — since those instructions are part of 
> the x86_64 baseline API it looks like the source at least does not 
> require x86_64-v2 or newer. (That was probably an entirely different 
> thing for x86).

I can't help with the general query, sorry.

David

> Gruss
> Bernd
> -- 
> http://bernd.eckenfels.net
> ------------------------------------------------------------------------
> *Von:* David Holmes <david.holmes at oracle.com>
> *Gesendet:* Freitag, August 25, 2023 3:57 AM
> *An:* Bernd Eckenfels <ecki at zusammenkunft.net>; hotspot-dev at openjdk.org 
> <hotspot-dev at openjdk.org>
> *Betreff:* Re: Older unused Intel platform check functions
> Hi Bernd,
> 
> On 25/08/2023 9:23 am, Bernd Eckenfels wrote:
>  > Hello,
>  >
>  > I was checking out to see a hint of what’s the minimum microarchitecture
>  > is, which makes sense to require for OpenJDK. I was not very successful
>  > and it probably depends on compiler toolchain and distribution. Does
>  > somebody have some insights?
>  >
>  > Having said that I noticed the following:
>  >
>  > The 20 years old netburst architecture has a test function but it’s not
>  > used to make feature decisions in the JDK, it is just used to construct
>  > a SSE feature string, where it can be safely removed (the feature flags
>  > are reported anyway, worst case use cpu_family_description instead?)
>  >
>  > VM_Version::is_netburst
>  >
>  > If you want to keep it, it’s probably more consistent to rename it to
>  > is_intel_netburst
> 
> Yes netburst seem unused now.
> 
>  >
>  > VM_Version::is_default_intel_cascadelake
>  > VM_Version::is_intel_cascadelake
>  >
>  > Those two seem not to be used anywhere, can probably be removed as well.
> 
> Yes they are used: ./cpu/x86/x86.ad ./cpu/x86/x86_64.ad
> 
> Cheers,
> David
>