RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Tue Aug 29 07:07:11 UTC 2023
On Sun, 27 Aug 2023 17:03:00 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Not a review, just agreeing with @stefank and @jdksjolen . What they describe is idiomatic C++.
>
> Also, why isn't this change also being applied to `find_from_end`
There can be a confusion related to selection of type names T and E:
T is intuitively treated as a table and E as an element.
No pressure but I wonder if using D instead of T would be better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1308303916
More information about the hotspot-dev
mailing list