RFR: 8315069: Relativize extended_sp in interpreter frames [v2]

Fredrik Bredberg fbredberg at openjdk.org
Wed Aug 30 15:24:04 UTC 2023


On Wed, 30 Aug 2023 13:31:09 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updated aarch64 after review
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.hpp line 89:
> 
>> 87:     Label L;
>> 88:     ldr(rscratch1, Address(rfp, frame::interpreter_frame_extended_sp_offset * wordSize));
>> 89:     lea(rscratch1, Address(rfp, rscratch1, Address::lsl(3)));
> 
> Suggestion:
> 
>     lea(rscratch1, Address(rfp, rscratch1, Address::lsl(LogBytesPerWord)));

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15468#discussion_r1310441531


More information about the hotspot-dev mailing list