RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v2]

[David Holmes]

On Wed, 30 Aug 2023 22:58:41 GMT, Jonathan Joo <jjoo at openjdk.org> wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address dholmes@ comments

src/hotspot/share/gc/shared/collectedHeap.cpp line 280:

> 278:     _perf_parallel_gc_threads_cpu_time =
> 279:                 PerfDataManager::create_variable(NULL_NS, "par_gc_thread_time",
> 280:                                                  PerfData::U_Ticks, CHECK);

Shouldn't this initialization be guarded like the others?

src/hotspot/share/runtime/vmThread.cpp line 142:

> 140:     _perf_vm_thread_cpu_time =
> 141:                  PerfDataManager::create_variable(NULL_NS, "vm_thread_time",
> 142:                                                   PerfData::U_Ticks, CHECK);

Again should not this initialization be guarded like the others.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1311123866
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1311124544