RFR: 8318217: RISC-V: C2 VectorizedHashCode [v7]

Yuri Gaevsky duke at openjdk.org
Fri Dec 1 20:28:39 UTC 2023


On Fri, 1 Dec 2023 17:00:53 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> I have just borrrowed that part of code from X86 counterpart:
>>   https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp#L3354
>> It is a dead code so 'ShouldNotReachHere();' looks more appropriate here. Do you think we should fix this as a part of this patch or as some follow-ups for both x86/RISC-V?
>
> Yes, as we already have `ShouldNotReachHere();` to guard the default case. How do you think about it?

Oops, somehow I completely missed that ShouldNotReachHere() is already in place, will fix that shortly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16629#discussion_r1412544588


More information about the hotspot-dev mailing list