RFR: 8320935: Move CDS config initialization code to cdsConfig.cpp [v2]

[Thomas Stuefe]

On Sat, 2 Dec 2023 00:38:58 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> This is a simple clean up that moves the code for initializing the CDS config states from arguments.cpp to cdsConfig.cpp
>> 
>> I renamed a few functions, but otherwise the code is unchanged.
>> 
>> - `get_default_shared_archive_path()` -> `default_archive_path()`
>> - `GetSharedArchivePath()` -> `static_archive_path()`
>> - `GetSharedDynamicArchivePath()` -> `dynamic_archive_path()`
>> 
>> There's also less `#if INCLUDE_CDS` since the entire cdsConfig.cpp file is compiled only if CDS is enabled.
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed indentation

Looks good. Did not find any functional difference to the original code.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16868#pullrequestreview-1760796058