RFR: JDK-8320892: AArch64: Restore FPU control state after JNI [v3]
David Holmes
dholmes at openjdk.org
Mon Dec 4 04:57:38 UTC 2023
On Tue, 28 Nov 2023 15:58:04 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Some buggy libraries corrupt the floating-point control register. Provide something similar to the x86 RestoreMXCSROnJNICalls.
>>
>> I realize that using the x86ish name "RestoreMXCSROnJNICalls" might be a little controversial, but it is a _global_ flag, not a CPU-specific one. And it's clearly intended for this purpose. It might have been better if that flag had been given a better name twentyish years ago, but we can't change it now.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix thinko
Also from arguments.cpp
* ALIASED: An option that is simply another name for another option. This is often
* part of the process of deprecating a flag, but not all aliases need
* to be deprecated.
*
* Create an alias for an option by adding the old and new option names to the
* "aliased_jvm_flags" table. Delete the old variable from globals.hpp (etc).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16851#issuecomment-1837841265
More information about the hotspot-dev
mailing list