RFR: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string

Evgeny Astigeevich eastigeevich at openjdk.org
Tue Dec 5 13:51:36 UTC 2023


On Tue, 5 Dec 2023 01:08:10 GMT, Yi-Fan Tsai <duke at openjdk.org> wrote:

> Test CheckLargePages was broken by the previous changes:
> 
> [JDK-8261894](https://bugs.openjdk.org/browse/JDK-8261894) removes `UseHugeTLBFS`. It was also removed from `os::can_execute_large_page_memory`, and `CodeCache::page_size` cannot  use huge pages anymore.
> 
> [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) changes the pagesize logs from
> 
> Usable page sizes: 4k, 1G
> 
> to
> 
> Large page support enabled. Usable page sizes: 4k, 1G. Default large page size: 1G.
> 
> 
> This change includes:
> - `os::can_execute_large_page_memory` uses `UseLargePages`, which could be implicitly enabled by `UseTransparentHugePages` as well.
> - The regular expression in CheckLargePages is updated to capture only the page sizes.
> - Test CheckLargePages is still kept in ProblemList.txt until [JDK-8319795](https://bugs.openjdk.org/browse/JDK-8319795)) is resolved.

Changes requested by eastigeevich (Committer).

src/hotspot/os/linux/os_linux.cpp line 4007:

> 4005: 
> 4006: bool os::can_execute_large_page_memory() {
> 4007:   return UseLargePages;

Could you please exclude this change from the PR? The function will be removed by my PR.

In `test/hotspot/jtreg/ProblemList.txt` could you please change

compiler/codecache/CheckLargePages.java 8317831 linux-x64


to

compiler/codecache/CheckLargePages.java 8319795 linux-x64

-------------

PR Review: https://git.openjdk.org/jdk/pull/16962#pullrequestreview-1765126244
PR Review Comment: https://git.openjdk.org/jdk/pull/16962#discussion_r1415642973


More information about the hotspot-dev mailing list