RFR: JDK-8320890: [AIX] Find a better way to mimic dl handle equality [v3]

Thomas Stuefe stuefe at openjdk.org
Tue Dec 5 13:55:56 UTC 2023


On Tue, 5 Dec 2023 13:21:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   encapsulate everything in os::Aix::dlopen
>
> src/hotspot/os/aix/os_aix.cpp line 3133:
> 
>> 3131:         return nullptr;
>> 3132:       }
>> 3133:       // library not still loaded and still place in array, so load library
> 
> s/still/yet

No need to be this verbose either, especially since the comment is somewhat misleading. "create entry at end of table" implies that we have a dynamically growing table and allocate new entries. Proposal: "Library not yet loaded; load it, then store its handle in handle table".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16920#discussion_r1415605856


More information about the hotspot-dev mailing list