RFR: 8317831: compiler/codecache/CheckLargePages.java fails on OL 8.8 with unexpected memory string [v2]

[David Holmes]

On Tue, 5 Dec 2023 14:30:49 GMT, Yi-Fan Tsai <duke at openjdk.org> wrote:

>> Test CheckLargePages was broken by the previous changes:
>> 
>> [JDK-8310233](https://bugs.openjdk.org/browse/JDK-8310233) changes the pagesize logs from
>> 
>> Usable page sizes: 4k, 1G
>> 
>> to
>> 
>> Large page support enabled. Usable page sizes: 4k, 1G. Default large page size: 1G.
>> 
>> 
>> [JDK-8261894](https://bugs.openjdk.org/browse/JDK-8261894) removes `UseHugeTLBFS`. It was also removed from `os::can_execute_large_page_memory`, and `CodeCache::page_size` cannot  use huge pages anymore.
>> 
>> This change includes:
>> - The regular expression in CheckLargePages is updated to capture only the page sizes.
>> - The static huge page will be fixed by  [JDK-8319795](https://bugs.openjdk.org/browse/JDK-8319795).
>
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reserve only regular expression

I'm going to approve this test fix as the change to the regex itself seems reasonable, even though because the test remains excluded by [JDK-8319795](https://bugs.openjdk.org/browse/JDK-8319795) we won't actually be testing it. If any issues arise when the test is removed from the ProblemList it is expected that [JDK-8319795](https://bugs.openjdk.org/browse/JDK-8319795) will deal with that.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16962#pullrequestreview-1766409690