RFR: JDK-8321266: Add diagnostic RSS threshold [v2]

David Holmes dholmes at openjdk.org
Wed Dec 6 05:34:39 UTC 2023


On Wed, 6 Dec 2023 05:24:48 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback david
>
> src/hotspot/share/services/rsswatch.cpp line 120:
> 
>> 118:     log_warning(os, rss)("RssLimit specified, but not supported by the Operating System.");
>> 119:     return;
>> 120:   }
> 
> This seems a strange place for this. I would expect it to be in the init function.

Sorry -ignore this. The git UI had me confused about where this was.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16938#discussion_r1416685476


More information about the hotspot-dev mailing list