RFR: JDK-8321266: Add diagnostic RSS threshold [v3]

[Thomas Stuefe]

On Tue, 5 Dec 2023 05:49:58 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add specific percentage switch
>
> Hi Thomas,
> 
> I've taken a first pass through this and it seems okay in principle. A number of initial comments/suggestions below.
> 
> Thanks.

@dholmes-ora New Version:

I attempted to change the percentage parsing as you wished (for RssLimit=fraction-of-1.0) but then decided not to. I don't have the percentage sign to tell percentage form apart from absolute form. I cannot just use `scanf` with `%f` since that would also parse values without decimal point that are meant to be absolute. More importantly, I dislike decimal points in arguments - it makes usage, tests, and documentation locale-specific.

I opted, therefore, for a separate RssLimitPercent switch. We have many examples of switches that take percentage, and most of them are integers ranging 0..100. So, by adding this switch I followed standard procedure. I regret having a new switch, but on the bright side, I reuse the standard switch limit checks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16938#issuecomment-1842397114