RFR: 8319969: os::large_page_init() turns off THPs for ZGC [v5]

[Stefan Karlsson]

On Wed, 6 Dec 2023 09:28:09 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> There is code in `os::large_page_init()` that checks `/sys/kernel/mm/transparent_hugepage/enabled` and forcefully turns off `UseTransparentHugePages` if anonymous THPs are disabled in the OS:
>> 
>> 
>>   if (UseTransparentHugePages && !HugePages::supports_thp()) {
>>     if (!FLAG_IS_DEFAULT(UseTransparentHugePages)) {
>>       log_warning(pagesize)("UseTransparentHugePages disabled, transparent huge pages are not supported by the operating system.");
>>     }
>>     UseLargePages = UseTransparentHugePages = false;
>>     return;
>>   }
>> 
>> 
>> This is problematic because ZGC doesn't use the `/sys/kernel/mm/transparent_hugepage/enabled` THPs, but instead the `/sys/kernel/mm/transparent_hugepage/shmem_enabled` THPs. So, with the following settings:
>> 
>> /sys/kernel/mm/transparent_hugepage/enabled: never
>> /sys/kernel/mm/transparent_hugepage/shmem_enabled: advise
>> 
>> 
>> the above code will force ZGC to run without THPs.
>> 
>> This PR is a proposal for how to work around this in the ZGC code without disturbing the the rest of the JVM too much. The patch:
>> 
>> 1) remembers the initial values for UseLargePages and UseTransparentHugePages and saves those so that ZGC can continue using THPs even though they have been disabled for the rest of the JVM.
>> 
>> 2) adds better logic to figure out if ZGC is actually going to get THPs for the heap or not. This is then used to more accurately log the current situation and allows for a precise usage of `madvise + MADV_HUGEPAGE`.
>> 
>> 3) tweaks the generic pagesize logging to better reflect the situation when anonymous THPs are disabled but shared memory THPs are enabled and ZGC is used.
>> 
>> The result of this change can be seen in these tables:
>> 
>> ZGC large pages log output:
>> 
>> E (T)     = Enabled (Transparent)
>> E (T, OS) = Enabled (Transparent, OS enforced)
>> D         = Disabled
>> D         = Disabled (OS enforced)
>> 
>> -XX:+UseTransparentHugePages
>> 
>> shem \ anon | always | madvise | never
>> ------------+--------+---------+-------
>> always      | E (T)  | E (T)   | E (T)
>> within_size | E (T)  | E (T)   | E (T)
>> advise      | E (T)  | E (T)   | E (T)
>> never       | D (OS) | D (OS)  | D (OS)
>> deny        | D (OS) | D (OS)  | D (OS)
>> force       | E (T)  | E (T)   | E (T)
>> 
>> -XX:-UseTransparentHugePages
>> 
>> shem \ anon | always    | madvise   | never
>> ------------+-----------+-----------+-------
>> always      | E (T, OS) | E (T, OS) | E (T, OS)
>> within_size | E (T, OS) | E (T, OS) | E (T, OS)
>> advise      | D   ...
>
> Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8319969_zgc_thp_workaround
>  - More precise THP warning messages
>  - Move _thp_requested out from HugePages
>  - Small tweaks
>  - 8319969: os::large_page_init() turns off THPs for ZGC

Thanks all for reviewing!

I've run this through our tier1-tier5 testing.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16690#pullrequestreview-1768432046