RFR: 8237842: Separate definitions for default cache line and padding sizes [v2]
Aleksey Shipilev
shade at openjdk.org
Wed Dec 6 19:52:38 UTC 2023
On Wed, 6 Dec 2023 10:27:58 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> [JDK-8321137](https://bugs.openjdk.org/browse/JDK-8321137) needs a clean separation between cache line sizes and padding sizes. At least on x86, there is a wrinkle with "assuming" the cache line size is 128 bytes to cater for prefetchers. Cleanly separating cache line size and padding size resolves this. I rewrote uses of `DEFAULT_CACHE_LINE_SIZE` in padding contexts to new macro.
>>
>> The goal for this patch is to avoid actual values changes as much as possible. One of the changes come from cleaning up some of the old cases in x86 definition, thus simplifying the definition. I think the LP64 split is still useful there.
>>
>> Additional testing:
>> - [x] Large build matrix of server/zero builds
>> - [x] Linux AArch64 server fastdebug, `tier{1,2}`
>> - [x] Linux x86_64 server fastdebug, `tier{1,2}`
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Better verbiage for *2 adjustment for x86_64
> - Merge branch 'master' into JDK-8237842-cache-line-padding-defs
> - Work
I submitted the RFE for lifting the `*2` padding for x86_64 here:
https://bugs.openjdk.org/browse/JDK-8321481
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16973#issuecomment-1843588110
More information about the hotspot-dev
mailing list