RFR: 8321219: runtime/jni/FastGetField: assert(is_interpreted_frame()) failed: interpreted frame expected [v2]

[Serguei Spitsyn]

On Tue, 5 Dec 2023 23:01:20 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: extended comment to cover the watchpoint extra checks
>
> Thumbs up. This is a trivial fix.
> 
> You'll need to fix the whitespace complaint before integration.

> @dcubed-ojdk I would not consider this a trivial fix at all - the need to add the additional conditions is not at all obvious!
> And even if they were, that would make this a small/simple fix, not "trivial" as defined for the "one review needed" rule.

Sorry, David. It was kind of obvious to me as this tweak is a work around the field watch related regression.
Of course, it would better to wait for you to finish review but it was not clear if you are going to complete it or not.
As you know, it is very uncomfortable to do last minute push even if it is trivial. :(

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16961#issuecomment-1843587781