RFR: 8318158: RISC-V: implement roundD/roundF intrinsics [v6]

[Andrew Haley]

On Fri, 8 Dec 2023 08:52:35 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Olga Mikhaltsova has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replaced tmp with t0
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 4292:
> 
>> 4290:   // if +/-0, +/-subnormal numbers, signaling/quiet NaN
>> 4291:   andi(t0, t0, fclass_mask::nan | fclass_mask::zero | fclass_mask::subnorm);
>> 4292:   bnez(t0, done);
> 
> What is this subnorm test for?

It looks to me like RoundTests.java isn't testing denormals. But I guess you tested the entire 32-bit range against the Java code, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16382#discussion_r1420152675