RFR: 8318217: RISC-V: C2 VectorizedHashCode [v10]

Fei Yang fyang at openjdk.org
Sat Dec 9 01:48:18 UTC 2023


On Fri, 8 Dec 2023 14:14:46 GMT, Yuri Gaevsky <duke at openjdk.org> wrote:

>> The control flow will be directed to `DONE` by the `beqz` check at L1493 when `cnt` is zero.
>
> I meant other case(s): if '`cnt`' is equal to 4/8/... then after the initial `cnt==zero` check at L1493 the control flow _**doesn't jump**_ to `DONE ` but continue execution, _zeroed_ by `andi()` _before_ the wide loop, so after the loop the 'cnt' is zero (L1501) - that's why the check is needed.

Yes, I know what you mean. And that's also what I am suggesting in my initial comment: move this `beqz` check immediately after the loop (that is after L1522 in your latest version).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16629#discussion_r1421202679


More information about the hotspot-dev mailing list