RFR: 8321515: ARM32: Move method resolution information out of the cpCache properly [v3]

[Aleksei Voitylov]

On Mon, 11 Dec 2023 15:54:04 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Aleksei Voitylov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8321515
>>  - review comments
>>  - JDK-8321515 implementation
>
> src/hotspot/cpu/arm/interp_masm_arm.cpp line 311:
> 
>> 309:   get_index_at_bcp(index, bcp_offset, cache /* as tmp */, sizeof(u2));
>> 310: 
>> 311:   if (is_power_of_2(sizeof(ResolvedMethodEntry))) {
> 
> I usually dislike introducing split like these, because one of the branches is effectively dead. Which also means it is effectively untested. Given this interpreter code, can we just leave the generic version unconditionally?

Yes, it's gone in the new version.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17017#discussion_r1423899184