RFR: 8321404: Limit the number of heap dumps triggered by HeapDumpBeforeFullGC/AfterFullGC

Denghui Dong ddong at openjdk.org
Thu Dec 14 02:08:42 UTC 2023


On Wed, 6 Dec 2023 04:00:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of this patch?
>> 
>> In the current implementation, HeapDumpBeforeFullGC/AfterFullGC will generate dumps for every FGC, increasing the risk of disk full.
>> 
>> This patch introduces a new option 'FullGCHeapDumpLimit' to limit the number of dumps triggered by HeapDumpBeforeFullGC/AfterFullGC to enhance production-friendliness.
>> 
>> Best,
>> Denghui
>
> @D-D-H  adding a new manageable flag requires a CSR request to be approved.

@dholmes-ora Thanks for the review.

Could anyone in the serviceability area help review CSR and this patch?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16976#issuecomment-1854994491


More information about the hotspot-dev mailing list