RFR: 8319716: RISC-V: Add SHA-2 [v4]

Vladimir Kempik vkempik at openjdk.org
Fri Dec 15 11:34:42 UTC 2023


On Fri, 15 Dec 2023 11:11:59 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> Hi all, I have address all comments.
> 
> The only code change I didn't do was register caching of constants. This is because I don't have access to sha2 in performance simulator. Without it 256 and 512 have 'identical' path. I'll create a jira for that, so I can revisit it once I have access. I hope that is okay @RealFYang ? (i.e. ship this and do a follow-up)
> 
> Also @VladimirKempik the flag issue is not resolved. For now we use this experimental flag which is inline with the other flags.
> 
> Any other things to address, new or that I missed?
> 
> (passes compiler/intrinsics/sha/)

It was mostly a wish we look at flags later and simplify it

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16562#issuecomment-1857731028


More information about the hotspot-dev mailing list