RFR: JDK-8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library [v2]

David Holmes dholmes at openjdk.org
Fri Dec 15 12:43:40 UTC 2023


On Fri, 1 Dec 2023 09:05:22 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> [JDK-8295159](https://bugs.openjdk.org/browse/JDK-8295159) added some IEEE conformance checks and corrections of the floating point environment on Linux and macOS/BSD, and later some UL logging was added too.
>> However the information is not added to the JFR events, and this should be enhanced.
>> The already existing NativeLibraryLoad event can be used for storing the additional information, because the IEEE conformance check and fenv  get/set  is placed in the HS dlopen_helper , where already the NativeLibraryLoad  event objects are created/commited .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust macOS coding

I previously stated "JNI checking is for checking actual JNI API functions" but Thomas reminded me above that it also enables periodic checks e.g. for the signal handlers, so we already go beyond just checking JNI API function calls. Hence there is scope for performing these FP checks under -Xcheck:jni.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16903#issuecomment-1857822793


More information about the hotspot-dev mailing list