RFR: 8321404: Limit the number of heap dumps triggered by HeapDumpBeforeFullGC/AfterFullGC [v2]

Denghui Dong ddong at openjdk.org
Sat Dec 16 04:36:58 UTC 2023


On Sat, 16 Dec 2023 01:11:44 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 557:
>> 
>>> 555:           "Limit the number of heap dumps triggered by "                    \
>>> 556:           "HeapDumpBeforeFullGC or HeapDumpAfterFullGC "                    \
>>> 557:           "(0 means no limit)" )                                            \
>> 
>> nit: should be no space before the last paren.
>
> I was wondering if it is worth having HeapDumpBeforeFullGC and HeapDumpAfterFullGC also mention FullGCHeapDumpLimit. Just something simple like "Also see FullGCHeapDumpLimit." Not necessary, but if you think it would be useful then please add.

> nit: should be no space before the last paren.

fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16976#discussion_r1428685031


More information about the hotspot-dev mailing list