RFR: 8320069: RISC-V: Add Zcb instructions [v2]

Robbin Ehn rehn at openjdk.org
Wed Dec 20 06:52:32 UTC 2023


> Hi, this is the instructions for zcb.
> 
> Due to over lack of infrastructure having multiple extension dependent instruction does not fit well.
> Some of these compressed instructions are also missing 1 to 1 mapping, e.g. now we have a compressed not, but the corresponding instruction in uncompressed is still xor.
> I think we need to do some rework here.
> 
> I also I don't like the macro expansion as it hopeless in debugger and 'IDE's (vim+rtags for me).
> (macro stuff was originally done when templates where blacklisted in hotspot)
> 
> And I don't want an option for this, as zcb is coming in hwprobe, if you have compressed on you get them if they are supported (may depend on e.g. zbb).
> 
> I have done some modification since it passed tier1, so I'm running stuff over the weekend.

Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into zcb
 - zcb instruction set

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17122/files
  - new: https://git.openjdk.org/jdk/pull/17122/files/38d94725..f0206e57

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17122&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17122&range=00-01

  Stats: 2228 lines in 156 files changed: 1524 ins; 268 del; 436 mod
  Patch: https://git.openjdk.org/jdk/pull/17122.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17122/head:pull/17122

PR: https://git.openjdk.org/jdk/pull/17122


More information about the hotspot-dev mailing list