RFR: JDK-8321017: Record in JFR that IEEE rounding mode was corrupted by loading a library [v2]

Matthias Baesken mbaesken at openjdk.org
Wed Dec 20 13:52:04 UTC 2023


On Wed, 20 Dec 2023 13:43:42 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust macOS coding
>
> src/hotspot/share/jfr/metadata/metadata.xml line 961:
> 
>> 959:     <Field type="string" name="errorMessage" label="Error Message" description="In case of a load error, error description" />
>> 960:     <Field type="boolean" name="fpEnvCorrectionAttempt" label="FPU Environment correction" description="In case of IEEE conformance issues we might reset the FP environment" />
>> 961:     <Field type="boolean" name="fpEnvCorrectionSuccess" label="FPU Environment correction result" description="Stores result in case FP environment correction" />
> 
> minor grammatical issue: "Stores the result in the case of an FP environment correction" is better

Thanks, I adjusted the description.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16903#discussion_r1432737259


More information about the hotspot-dev mailing list