RFR: 8319716: RISC-V: Add SHA-2 [v4]

[Robbin Ehn]

On Fri, 15 Dec 2023 11:32:26 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

>> Hi all, I have address all comments.
>> 
>> The only code change I didn't do was register caching of constants.
>> This is because I don't have access to sha2 in performance simulator.
>> Without it 256 and 512 have 'identical' path.
>> I'll create a jira for that, so I can revisit it once I have access.
>> I hope that is okay @RealFYang ? (i.e. ship this and do a follow-up)
>> 
>> Also @VladimirKempik the flag issue is not resolved.
>> For now we use this experimental flag which is inline with the other flags.
>> 
>> Any other things to address, new or that I missed?
>> 
>> (passes compiler/intrinsics/sha/)
>> 
>> REF: https://bugs.openjdk.org/browse/JDK-8322177
>
>> Hi all, I have address all comments.
>> 
>> The only code change I didn't do was register caching of constants. This is because I don't have access to sha2 in performance simulator. Without it 256 and 512 have 'identical' path. I'll create a jira for that, so I can revisit it once I have access. I hope that is okay @RealFYang ? (i.e. ship this and do a follow-up)
>> 
>> Also @VladimirKempik the flag issue is not resolved. For now we use this experimental flag which is inline with the other flags.
>> 
>> Any other things to address, new or that I missed?
>> 
>> (passes compiler/intrinsics/sha/)
> 
> It was mostly a wish we look at flags later and simplify it

@VladimirKempik @RealFYang @Hamlin-Li are we all good now? Could I get some more approval if so :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16562#issuecomment-1865988689