RFR: 8301116: Parallelize TLAB resizing in G1

Thomas Schatzl tschatzl at openjdk.org
Wed Feb 1 10:42:32 UTC 2023


Hi all,

  can I get reviews for this change that moves TLAB resizing into the second parallel post evacuation phase?

The change is fairly straightforward except maybe for the following:
* there is a new claimer for `JavaThreads` because the `Threads::possibly_parallel_threads_do` method to parallelize does not work well with very little per-thread work. Actually with a moderate amount of threads (~20) performance would already be many times slower than doing things serially.
* moving the TLAB resizing out of `G1CollectedHeap::prepare_tlabs_for_mutator` made that method and the enclosing timing a bit obsolete, so I repurposed it as a "do preparatory work for the mutator during young gc" phase. That resulted in minor cleanup and regularization of what is done during that phase (wrt to what the corresponding method for full gc does).

Testing: gha, local perf testing, tier1

Thanks,
  Thomas

-------------

Commit messages:
 - Cleanup
 - Fixes, refactoring
 - Fixes
 - Cleanup
 - initial version

Changes: https://git.openjdk.org/jdk/pull/12360/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12360&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8301116
  Stats: 113 lines in 12 files changed: 77 ins; 20 del; 16 mod
  Patch: https://git.openjdk.org/jdk/pull/12360.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12360/head:pull/12360

PR: https://git.openjdk.org/jdk/pull/12360


More information about the hotspot-dev mailing list