RFR: JDK-8301050: Detect Xen Virtualization on Linux aarch64 [v2]

David Holmes dholmes at openjdk.org
Wed Feb 1 22:02:27 UTC 2023


On Wed, 1 Feb 2023 13:09:19 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> With https://bugs.openjdk.org/browse/JDK-8300266 KVM and VMWare virtualization detection has been added; this should be enhanced by Xen detection.
>> However it seems that for Xen we should look at other file system locations compared to the other virtualizations.
>> more /sys/hypervisor/type
>> xen
>> seems to be available there.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Do not scan the product_name file twice

src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 596:

> 594:   int resp = check_info_file(pname_file, "KVM", "VMWare");
> 595:   if (resp == 1) {
> 596:     Abstract_VM_Version::_detected_virtualization = KVM;

This may be what Christoph suggested by why not keep this in check_info_file so you don't need to map return codes. check_info_file could just be a bool function then.

-------------

PR: https://git.openjdk.org/jdk/pull/12217


More information about the hotspot-dev mailing list