RFR: JDK-8301499: Replace NULL with nullptr in cpu/zero

David Holmes dholmes at openjdk.org
Thu Feb 2 00:01:24 UTC 2023


On Tue, 31 Jan 2023 11:40:29 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory cpu/zero. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> ```c++
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> 
> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
> 
> Thanks!

Looks good. Thanks.

src/hotspot/cpu/zero/javaFrameAnchor_zero.hpp line 38:

> 36:   //  2 - saving a current state (javaCalls)
> 37:   //  3 - restoring an old state (javaCalls)
> 38:   // Note that whenever _last_Java_sp != null other anchor fields

nullptr

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12327


More information about the hotspot-dev mailing list