RFR: 8294402: Add diagnostic logging to VMProps.checkDockerSupport [v6]
David Holmes
dholmes at openjdk.org
Thu Feb 2 04:45:22 UTC 2023
On Wed, 1 Feb 2023 23:59:00 GMT, Mikhailo Seledtsov <mseledtsov at openjdk.org> wrote:
>> Add log() and logToFile() methods to VMProps for diagnostic purposes.
>
> Mikhailo Seledtsov has updated the pull request incrementally with one additional commit since the last revision:
>
> Removed logging condition as per review feedback
Okay I'm struggling with the best way to handle this. I think the problem is that the code currently contains logging output of different levels (ref unified logging in the VM) but we only have a binary on/off selection mechanism. I don't want to see all the logging all the time - too noisy. But I do want to see the logging of the stdout/stderr from the exec'd process any time it fails.
But I guess we could keep it all conditional on the property and have the task definition for the container tests set the property as suggested.
-------------
PR: https://git.openjdk.org/jdk/pull/12239
More information about the hotspot-dev
mailing list