RFR: 8296344: Remove dependency on G1 for writing the CDS archive heap [v2]

[Ashutosh Mehra]

On Tue, 31 Jan 2023 16:11:13 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Goals
>> 
>> - Simplify the writing of the CDS archive heap
>>     - We no longer need to allocate special "archive regions" during CDS dump time. See all the removed G1 code. 
>> - Make it possible to (in a future RFE) write the CDS archive heap using any garbage collector
>> 
>> Implementation - the following runs inside a safepoint so heap objects aren't moving
>> 
>> - Find all the objects that should be archived
>> - Allocate buffer using a GrowableArray
>>     - Copy all "open" objects into the buffer
>>     - Copy all "closed" objects into the buffer
>> - Make sure the heap image can be mapped with all possible G1 region sizes: 
>>     - While copying, add fillers to make sure no object spans across 1MB boundary (minimal G1 region size)
>>     - Align the bottom of the "open" and "closed" objects at 1MB boundary
>> - Write the buffer to disk as the image for the archive heap
>> 
>> Testing: tiers 1 ~ 5
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed windows and 32-bit builds which do not support archive heap

src/hotspot/share/cds/archiveHeapWriter.cpp line 175:

> 173: 
> 174: oop ArchiveHeapWriter::heap_roots_requested_address() {
> 175:   return cast_to_oop(_requested_open_region_bottom + _heap_roots_bottom);

A suggestion: it is probably better to use the internal method `requested_obj_from_buffer_offset(_heap_roots_bottom)` instead.

-------------

PR: https://git.openjdk.org/jdk/pull/12304