Integrated: 8301564: Non-C-heap allocated ResourceHashtable keys and values must have trivial destructor

[Ioi Lam]

On Tue, 31 Jan 2023 23:23:16 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> To ensure we don't have memory leaks or other more serious memory management bugs, I added static asserts to check that the `K` and `V` types for `ResourceHashtableBase` must have trivial destructors if the table is not `C_HEAP` allocated. Thanks to @JornVernee for the original assert code.
> 
> The asserts actually found a problem with `ClassLoaderStatsClosure::StatsTable`. The space used by the `oop` in the freed hashtable may be trashed when `-XX:+CheckUnhandledOops` is enabled, so live objects that reuse the same space may be corrupted. (I tried but couldn't get it to fail).
> 
> I also had to change `CodeBuffer::SharedTrampolineRequests` because it's `V` type is `LinkListImpl<int>`, which has a non-trivial destructor. (Note: in this case, the destructor doesn't do anything; we can probably make it go away with C++-20. See https://stackoverflow.com/questions/40094871/sfinae-away-a-destructor)
> 
> Testing with tier1~4 + builds-tier5

This pull request has now been integrated.

Changeset: 04278e6b
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/04278e6bf2da501542feb777ab864bbcc5794fd0
Stats:     21 lines in 6 files changed: 14 ins; 0 del; 7 mod

8301564: Non-C-heap allocated ResourceHashtable keys and values must have trivial destructor

Reviewed-by: coleenp, jvernee

-------------

PR: https://git.openjdk.org/jdk/pull/12355