RFR: 8300255: Introduce interface for GC oop verification in the assembler

[Fei Yang]

On Mon, 6 Feb 2023 15:32:50 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

> In the assembly code, there is some generic oop verification code. Said verification may or may not fit a particular GC. In particular, it has not worked well for ZGC for a while, and there is an if (UseZGC). This enhancement aims at generalizing this code, such that a collector can have its own oop verification policy.

Hi, seems we need two extra small changes to build on linux-riscv. Thanks.

src/hotspot/cpu/riscv/gc/z/zBarrierSetAssembler_riscv.cpp line 450:

> 448: #define __ masm->
> 449: 
> 450: void BarrierSetAssembler::check_oop(MacroAssembler* masm, Register obj, Register tmp1, Register tmp2, Label& error) {

Should be 'ZBarrierSetAssembler::check_oop' here.

src/hotspot/cpu/riscv/gc/z/zBarrierSetAssembler_riscv.hpp line 103:

> 101: #endif // COMPILER2
> 102: 
> 103:   virtual void check_oop(MacroAssembler* masm, Register obj, Register tmp1, Register tmp2, Label& error);

Need to remove 'virtual' here.

-------------

Changes requested by fyang (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12443