RFR: 8300255: Introduce interface for GC oop verification in the assembler [v3]

Axel Boldt-Christmas aboldtch at openjdk.org
Thu Feb 9 13:13:46 UTC 2023


On Wed, 8 Feb 2023 10:19:20 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> In the assembly code, there is some generic oop verification code. Said verification may or may not fit a particular GC. In particular, it has not worked well for ZGC for a while, and there is an if (UseZGC). This enhancement aims at generalizing this code, such that a collector can have its own oop verification policy.
>
> Erik Österlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   RISC-V fixes

lgtm.

src/hotspot/cpu/aarch64/gc/z/zBarrierSetAssembler_aarch64.cpp line 455:

> 453: void ZBarrierSetAssembler::check_oop(MacroAssembler* masm, Register obj, Register tmp1, Register tmp2, Label& error) {
> 454:   // Check if mask is good.
> 455:   // verifies that ZAddressBadMask & r0 == 0

Update comment `s/r0/obj`

-------------

Marked as reviewed by aboldtch (Committer).

PR: https://git.openjdk.org/jdk/pull/12443


More information about the hotspot-dev mailing list