RFR: 8301697: [s390] Optimized-build is broken

Amit Kumar duke at openjdk.org
Thu Feb 9 18:27:34 UTC 2023


On Fri, 3 Feb 2023 04:34:46 GMT, Amit Kumar <duke at openjdk.org> wrote:

> This fix guards `__ asm_assert_eq("killed Z_R14", 0)` & `__asm_assert_mem8_is_zero(in_bytes(JavaThread::exception_pc_offset()), Z_thread, "exception pc already set : "FILE_AND_LINE, 0)` with ASSERT because on s390x  `JavaThread::exception_oop_offset()` is always cleared but `JavaThread::exception_pc_offset()` is being cleared only in ASSERT-def, Which is causing the build failure in Optimized-Debug.

Hi @shipilev , @theRealAph 

As title states optimized build is broken with GCC-9.4.0 and After my code changes build is now again successful. I've done testing for optimised, release, fastdebug, slowdebug on s390 and they're successful with these code changes. 

I'm pinging you here, because I've seen a patch for build-fix for optmized-build in past from you. 
form shipilev : https://github.com/openjdk/jdk/pull/10743  (for s390)
from theRealAph: https://github.com/openjdk/jdk/pull/9103 (for arch-64).

As I'm new to OpenJDK, so it would be helpful if you could share some insight about this fix or any other way to fix the build, before I mark this PR "ready for review".

Thank you so much.

-------------

PR: https://git.openjdk.org/jdk/pull/12400


More information about the hotspot-dev mailing list