RFR: 8301819: Enable continuations code by default [v2]

Hao Sun haosun at openjdk.org
Fri Feb 10 03:55:47 UTC 2023


On Thu, 9 Feb 2023 17:31:28 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> The continuations code added in JDK 19 with JEP 425 is currently disabled by default and is only enabled when running with preview features enabled (`--enable-preview`). Disabled by default was the pragmatic choice at that time to reduce risk and possible performance regressions. We'd like to change this so the code is enabled by default on the platforms that have a port. Enabling this code by default helps to shake out any issues early in JDK 21 and sets things up to make virtual threads a permanent feature in the future. If something comes up in the next few weeks/months then it can be changed to be disabled by default again. This change has no impact on the builds that do not have a port.
>> 
>> Testing: tier1-tier6
>
> Alan Bateman has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge
>  - Update copyright date
>  - Initial commit

src/hotspot/share/runtime/continuation.cpp line 416:

> 414: // While virtual threads are in Preview, there are some VM mechanisms we disable if continuations aren't used
> 415: bool Continuations::enabled() {
> 416:   return VMContinuations && Arguments::enable_preview();

With this change, I think header file `"runtime/arguments.hpp"` at line 29 can be excluded.

-------------

PR: https://git.openjdk.org/jdk/pull/12459


More information about the hotspot-dev mailing list