RFR: 8301697: [s390] Optimized-build is broken

Lutz Schmidt lucy at openjdk.org
Fri Feb 10 17:29:03 UTC 2023


On Fri, 10 Feb 2023 04:07:39 GMT, Amit Kumar <duke at openjdk.org> wrote:

>> src/hotspot/cpu/s390/c1_Runtime1_s390.cpp line 3:
>> 
>>> 1: /*
>>> 2:  * Copyright (c) 2016, 2023, Oracle and/or its affiliates. All rights reserved.
>>> 3:  * Copyright (c) 2016, 2023, SAP SE. All rights reserved.
>> 
>> As I understand it, only SAPers should touch the SAP copyright header. I recognize that this is a bit confusing because everyone updates the Oracle header.
>> 
>> If @RealLucy confirms this to be true, please keep the Oracle line update, and revert the SAP line.
>
> would you suggest that we add IBM copyright header here as well ?

Here is the "common practice" for updating copyright headers:

- Everybody updates the Oracle copyright line if there was a change, however small, in the file.
- Everybody can (but doesn't have to) update the SAP copyright line if there was a change.
- Please note: the SAP copyright does not have a comma after the last year.
- Adding the own company's copyright line is regarded acceptable only in case of major contributions/changes.

-------------

PR: https://git.openjdk.org/jdk/pull/12400


More information about the hotspot-dev mailing list