RFR: 8302262: Remove -XX:SuppressErrorAt develop option

[David Holmes]

On Sat, 11 Feb 2023 11:29:35 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Interesting. Thanks for explaining this. So the fact that we set the assert triggers the compiler check.

For the public record I was a supporter of the use of `SuppressErrorAt` as I have often found it useful when reproducing product failures on debug builds. I was also frustrated that the assertion triggers the extra compiler checks - a classic example, to me, of the compiler trying to be too clever/helpful and actually just causing problems.

But I have been persuaded that the trade-offs come down (slightly) in favour of removing `SuppressErrorAt`, even though for me build times are slow enough that disabling the problem  assertion is still an inconvenience.

-------------

PR: https://git.openjdk.org/jdk/pull/12521