RFR: 8139457: Array bases are aligned at HeapWord granularity [v11]

[Roman Kennke]

On Thu, 19 Jan 2023 11:26:22 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>> 
>>  - Merge branch 'master' into JDK-8139457
>>  - Fix gtest for correct base offsets in 32bit builds
>>  - Fix cast warning
>>  - Revert relaxation of array length
>>  - Add guards to ArrayBaseOffsets test to allow running with -UseCompressedClassPointers
>>  - Fix another cast warning
>>  - Clean cast warning from size_t to int
>>  - Clear leading 32bits in Z array allocator
>>  - SA adjustments
>>  - Test for 32bit build
>>  - ... and 15 more: https://git.openjdk.org/jdk/compare/500b45e1...c278a53b
>
> I tried to read the code very carefully, but it's not entirely easy to review a patch like this. I think I found two bugs, and a number of things that I think could help the readability of the code.
> 
> I didn't look to closely at the tests, but I think I'd like to see a test that checks the boundary conditions of the max array calculations.
> 
> I'd suggest that more Reviewers take a close look at the code.

@stefank @shipilev are you ok with the change now?

-------------

PR: https://git.openjdk.org/jdk/pull/11044