RFR: 8301697: [s390] Optimized-build is broken [v3]
Lutz Schmidt
lucy at openjdk.org
Mon Feb 13 13:41:29 UTC 2023
On Mon, 13 Feb 2023 10:45:57 GMT, Amit Kumar <duke at openjdk.org> wrote:
>> This fix guards `__ asm_assert_eq("killed Z_R14", 0)` & `__asm_assert_mem8_is_zero(in_bytes(JavaThread::exception_pc_offset()), Z_thread, "exception pc already set : "FILE_AND_LINE, 0)` with ASSERT because on s390x `JavaThread::exception_oop_offset()` is always cleared but `JavaThread::exception_pc_offset()` is being cleared only in ASSERT-def, Which is causing the build failure in Optimized-Debug.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> reverting extra copyright header updates
Changes look good to me. Thank you for tracking down and fixing this.
As discussed off-list, you may want to file a separate RFE to execute the checking code only #ifdef ASSERT.
-------------
Marked as reviewed by lucy (Reviewer).
PR: https://git.openjdk.org/jdk/pull/12400
More information about the hotspot-dev
mailing list