RFR: 8224980: FLAG_SET_ERGO silently ignores invalid values [v2]

Ioi Lam iklam at openjdk.org
Tue Feb 14 05:15:15 UTC 2023


> Clarify the `FLAG_SET_ERGO` API - the caller must ensure that a valid value is passed. Added an assert to check this.
> 
> Fixed two issues found by the assert:
> 
> - `NonNMethodCodeHeapSize`
> - `XXXThreshold` and `XXXNotifyFreqLog` flags in `CompilerConfig::set_compilation_policy_flags()`

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  @dholmes-ora comment - make sure errors are printed for FLAG_SET_ERGO

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12549/files
  - new: https://git.openjdk.org/jdk/pull/12549/files/a41c3989..adef377e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12549&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12549&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/12549.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12549/head:pull/12549

PR: https://git.openjdk.org/jdk/pull/12549


More information about the hotspot-dev mailing list