RFR: 8224980: FLAG_SET_ERGO silently ignores invalid values [v3]

David Holmes dholmes at openjdk.org
Wed Feb 15 06:23:44 UTC 2023


On Tue, 14 Feb 2023 22:06:24 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Clarify the `FLAG_SET_ERGO` API - the caller must ensure that a valid value is passed. Added an assert to check this.
>> 
>> Fixed two issues found by the assert:
>> 
>> - `NonNMethodCodeHeapSize`
>> - `XXXThreshold` and `XXXNotifyFreqLog` flags in `CompilerConfig::set_compilation_policy_flags()`
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @dholmes-ora suggestion

Looks good.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12549


More information about the hotspot-dev mailing list