RFR: 8301992: Embed SymbolTable CHT node [v2]

[Calvin Cheung]

On Wed, 15 Feb 2023 00:51:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @coleenp and @iklam comments
>
> src/hotspot/share/oops/symbol.cpp line 68:
> 
>> 66: }
>> 67: 
>> 68: Symbol::Symbol(const Symbol& s1) {
> 
> Can you add a comment that this copies the symbol when added to the ConcurrentHashTable.

I've added a comment and have pushed a commit based on your and Ioi's comments.
For now, I've changed the parameter name in `do_add_if_needed()` from `heap` to `is_permanent` and adjusted the callsites accordingly.

-------------

PR: https://git.openjdk.org/jdk/pull/12562