RFR: 8224980: FLAG_SET_ERGO silently ignores invalid values [v2]

Tobias Holenstein tholenstein at openjdk.org
Thu Feb 16 12:21:41 UTC 2023


On Wed, 15 Feb 2023 06:28:57 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Okay - whether this should produce warnings is a distinct issue for compiler folk to decide.
>
> I think it's fine to cap the values of the individual thresholds at their maximum without a warning, when `CompileThresholdScaling` is used.
> 
> Similar issues were already discussed in https://github.com/openjdk/jdk/pull/8501.
> 
>> I suggest to address this issue in a separate RFE.
> 
> @tobiasholenstein did you file that separate RFE?

> I think it's fine to cap the values of the individual thresholds at their maximum without a warning, when `CompileThresholdScaling` is used.
> 
> Similar issues were already discussed in #8501.
> 
> > I suggest to address this issue in a separate RFE.
> 
> @tobiasholenstein did you file that separate RFE?

No I did not file an RFE back then. But it seems like this PR resolves the issue

-------------

PR: https://git.openjdk.org/jdk/pull/12549


More information about the hotspot-dev mailing list